joinmarket-webui/jam

Fee and minimum size setting in market maker offer not deleted after stopping service and applying changes

Closed this issue · 1 comments

AchimDN commented

If one creates a market order "Earn" and accidentally hits the "Start Earning!" button before changing the default offer options (0.03% relative fee / minimum 100.000 sats) it is clear that the offer is spread in the network. However hitting the "Stop" button should fully delete the order and fee / minimum size settings.

The actual behaviour is that even though an offer, that was started accidentally with default fees, was stopped within less than a minute, and a new offer with higher minimum amount value was started, there was a coinjoin accepted with the previous minimum size setting.

Steps to reproduce the problem:

  1. Set the fee rate and minimum amount to default values e.g. 0.03% relative / minimum 100.000 sats
  2. Hit the "Start" button to start your offer
  3. Wait until Jam has finalised the offer and showing the counterparty ID
  4. Stop the current offer
  5. Change the fee rate to other values e.g. 0.01% relative / minimum 5.000.000 sats
  6. Check the earnings report if you have taken orders with sat values < 5.000.000 sats

Specifications

  • Version: 0.1.6.
  • Platform: Umbrel
  • Browser: Safari 17.0
AchimDN commented

Copied the issue to the JM repo

  • 👍1