joinmarket-webui/jam

feat: adapt `absurd_fee_per_kb` setting

Opened this issue · 5 comments

theborakompanioni commented

Currently, absurd_fee_per_kb is hardcoded in Jam and used when validating the fee settings.
absurd_fee_per_kb should be customizable by the user and it should be taken into account when validating fee values.

e.g. a user setting tx fee to 349 sats/vbyte with 20% randomization factor will likely have this tx failing without being properly informed exactly why (tx fee > absurd fee).

kristapsk commented

Jam could warn user and if he still agrees dynamically raise absurd_fee_per_kb setting.

  • 👍1
theborakompanioni commented

Jam could warn user and if he still agrees dynamically raise absurd_fee_per_kb setting.

Yep. Generally "fees and estimates" and how it is best possible to display information to a user so he has even the slightest ideas of what is going on is rather tricky with the API at the moment. It is suboptimal when all possible settings are displayed. The UI should remain simple, but still somehow allow you to adapt most options. Thank God I'm not a designer and @editwentyone has to deal with that and will find a proper solution 🤞

kristapsk commented

Here's my proposal for sendpayment.py - JoinMarket-Org/joinmarket-clientserver#1636.

theborakompanioni commented

Here's my proposal for sendpayment.py - JoinMarket-Org/joinmarket-clientserver#1636.

I appreciate the hint @kristapsk 🙏 This could be a viable solution in the web ui too. This, or prompting the user to adapt the absurd_fee_per_kb before the transaction.

  • 👍1
kristapsk commented

I was briefly thinking maybe RPC should also adjust absurd fee if manual fee is specified above it, but decided that probably it's not a good idea, better to require clients to use configset to override it manually, it's safer.

  • 👍1