go-to-definition sometimes lands on the wrong line (but correct file, at least)

Question

go-to-definition sometimes lands on the wrong line (but correct file, at least)

Opened this issue a year ago · 4 comments

jokeyrhyme commented a year ago

we've noticed that go-to-definition isn't always very accurate in terms of row/column
need to double-check the behaviour of the the VSCode extension in real VSCode

Answer 1 · 2023-10-10T00:29:12.000Z

Without any actual investigation, I do wonder if this is related to #10 ?

Answer 2 · 2023-10-12T06:29:33.000Z

I cannot reproduce this issue in https://github.com/nushell/vscode-nushell-lang 1.7.0 with Visual Studio Code 1.83.0

So, the issue is somewhere in nuls

Answer 3 · 2023-10-13T10:07:05.000Z

Hmmm, the document contents are stored in String and str types (UTF-8) in various places, but all the offsets are for UTF-16 content, and I think this might be an area that needs to be investigated

Answer 4 · 2023-10-17T01:31:59.000Z

I can confirm that this is happening in Visual Studio Code, and not just helix