Simplify again your testing environment
Closed this issue · 6 comments
Hi,
- A) using
MicroKernelTrait
could simplify your AppKernel class and remove the controller - B) also, we can use a
dataProvider
in test class
Bonus: faster tests (lol !) and a chance to play with the MicroKernelTrait
, use a dataProvider remove some duplicates, too.
If you agree, I can provide a pull request for A, B or A & B.
I really really like these ideas. However this bundle is compatible and tested with Symfony from version 2.3 to ~3.0. Sadly - if I'm right, even if we drop support for SF 2.3, the micro kernel tests wouldn't work for Symfony 2.7, which is still a maintained version. So I'm 👍 for B for now, unless you have an idea to simplify the test application 😉
the micro kernel tests wouldn't work for Symfony 2.7
2.8 is LTS too, because of time "mistake" AFAIK.
This is not a big deal to bump support to ^2.8
instead of ^2.7
.
This what we will do for Sonata: sonata-project/dev-kit#51
Yeah but supporting 2.7 and even 2.3 is not a problem at all currently. And we are talking to drop support of these versions only to simplify tests, so I'm not sure it’s worth it for now
Quite agree.
Your choice! 😉
Indeed. Thanks