Plan to use `ruflin/elastica` version 8?

Question

Plan to use `ruflin/elastica` version 8?

jmariller opened this issue 6 months ago · 28 comments

jmariller commented 6 months ago

Hi,

First of all thank you for this library :-)

I am wondering if it is planned to use version 8 of ruflin/elastica, and if so when more or less?

Many thanks

Answer 1 · 2024-05-24T08:29:39.000Z

We would be happy to see Pull Request about this yes. Can you work on this?

Some difficulties could arise:

the connections pool is now based on Elasticsearch custom https://github.com/elastic/elastic-transport-php - so our Symfony HttpClient bridge must probably be changed;
it will probably stop working with OpenSearch, see elastic/elasticsearch-php#1347 (not tested)

I would love for our project to be compatible with both 7 and 8.

Answer 2 · 2024-05-24T08:34:27.000Z

Thank you @damienalexandre for your quick feedback! Sure I can invest some time to try & contribute 🙂

Answer 3 · 2024-05-24T09:15:46.000Z

also I forgot to mention that I am not sure if we can make it work with both versions, as the namespace for different classes (e.g. Client) has changed between 7 and 8.

Answer 4 · 2024-05-29T12:30:27.000Z

The 8.0.0 version is now released https://github.com/ruflin/Elastica/releases/tag/8.0.0

Answer 5 · 2024-06-05T14:27:12.000Z

Thanks @VincentLanglet for the update!

@damienalexandre so I started to work on it and now I get following error message for many of the PhpUnit tests:
Elastic\Transport\Exception\NoNodeAvailableException: Exceeded maximum number of retries (1)

I am missing anything, should I set some environment/configuration value?

Answer 6 · 2024-06-05T14:37:02.000Z

The tests are running against a real Elasticsearch.

You can run this:

make start
make test
make stop

It will boot a ES node via Docker and expose port 9999 (we don't use the default 9200 port to avoid touching any real Elasticsearch node you may have on your computer).

Answer 7 · 2024-06-06T06:52:00.000Z

I had actually tried to start the docker ES node as I saw the makefile, however I still get exactly the same error message 😞 any other idea?

Answer 8 · 2024-07-03T13:42:30.000Z

hi @damienalexandre so I tried once again to make this work without success, would you have any other hint?

Answer 9 · 2024-07-03T13:46:02.000Z

Could you show the console output?
Can you run docker ps?

Answer 10 · 2024-07-03T13:56:31.000Z

sure, here it is:

console output (just an extract)

docker ps

Answer 11 · 2024-07-03T13:59:12.000Z

Can you open http://127.0.0.1:9999/ in a browser?

What does curl http://127.0.0.1:9999/ get you?

Answer 12 · 2024-07-03T14:02:24.000Z

This is what I get when opening this in a browser:

And with curl (essentially the same):

Answer 13 · 2024-07-03T14:08:45.000Z

I don't know what's happening but:

you have a working php
you have a working elasticsearch

Is there something we don't know? Do you have a proxy?

Can you go to http://127.0.0.1:9999/_cluster/health?pretty and paste the result?

Answer 14 · 2024-07-03T14:10:15.000Z

Thanks for taking the time to help 🙏

Here is the outcome of that URL:

{
"cluster_name": "docker-cluster",
"status": "green",
"timed_out": false,
"number_of_nodes": 1,
"number_of_data_nodes": 1,
"active_primary_shards": 0,
"active_shards": 0,
"relocating_shards": 0,
"initializing_shards": 0,
"unassigned_shards": 0,
"delayed_unassigned_shards": 0,
"number_of_pending_tasks": 0,
"number_of_in_flight_fetch": 0,
"task_max_waiting_in_queue_millis": 0,
"active_shards_percent_as_number": 100
}

Answer 15 · 2024-07-03T14:24:41.000Z

Status green, it should work!

You test from "master" or with your updated dependencies? It looks like the Elastica client is not properly configured, that may be a regression from version 8.

Answer 16 · 2024-07-03T14:28:21.000Z

aaah got it, it is indeed an issue from version 8! I reverted my changes and it works fine 🎉 alright then, I need to investigate further 😅 thanks again so much for your support 🙏

ps: if anyone sees this and wants to help too, please do 🙂

Answer 17 · 2024-07-04T12:57:19.000Z

FYI elastic/elasticsearch-php 8.0 is no more compatible with alternative servers like opensearch.

There is a mechanism that checks the headers elastic/elasticsearch-php#1229

Answer 18 · 2024-07-04T13:29:20.000Z

thanks @jderusse I have actually also just noticed the same while trying to run the tests with elasticsearch without updating the docker image 👍

@damienalexandre I am making some progress, now some more tests are green 🎉

Answer 19 · 2024-07-05T14:08:29.000Z

short update, now I have all tests green besides the one for the HttpClientTransport where I might need some help - I'll do as much as I can 🙂