joltwallet/esp_littlefs

is it possible to support larger sdcard by changing SIZE_MAX

Closed this issue ยท 6 comments

wang33winner commented

if i use a sdcard larger than 4GiB, ther will be a warinning says "SD card is too big ..."
and i checked the code is here:

        size_t max_allowed_blk_cnt = 0;
        if (((uint64_t)sdcard->csd.capacity * (uint64_t)sdcard->csd.sector_size) > SIZE_MAX) {
            max_allowed_blk_cnt = SIZE_MAX / sdcard->csd.sector_size;
            ESP_LOGW(ESP_LITTLEFS_TAG, "SD card is too big (sector=%d, count=%d; total=%llu bytes), throttling to maximum possible %u blocks",
                     sdcard->csd.sector_size, sdcard->csd.capacity,
                     (((uint64_t)sdcard->csd.capacity * (uint64_t)sdcard->csd.sector_size)), max_allowed_blk_cnt);
        } else {
            max_allowed_blk_cnt = sdcard->csd.capacity;
        }

so is it possible to change SIZE_MAX to 0xffffffffffffffffull?
maybe some changes should also to be done in get_total_and_used_bytes๏ผŒis there any other limits for SIZE_MAX ?

BrianPugh commented

LittleFS previously claimed to somewhat support up-to 4GB filesystems, but this has been formally rolled back in the latest release v2.9 (which I should update & released a new version of esp_littlefs) to 2GB. The >2GB functionality wasn't well tested. So, if I were you, I wouldn't attempt to use a partition larger than 2GB with littlefs.

huming2207 commented

Yea @BrianPugh is correct.

Plus this port also uses 32-bit counters & calculations everywhere (e.g. on block counts etc.), I don't think it will work even if LittleFS itself support something bigger than 2GB (or 4GB).

However I think it's worthy to discuss about using or even creating partitions (particularly GPT partitions, or at very least MBR) on SD card. Otherwise there's no way to make the full use on any modern SD card bigger than 2GB.

huming2207 commented

I've just had a look on this and I think porting MBR is definitely possible. On top of that GPT partition table is also doable but it's a bit overkill for microcontrollers. ๐Ÿ˜…

Meanwhile esp_partition is also usable, but needs quite a bit hacks. The size and address fields in esp_partition are all uint32_t which is limited to 4GB. I guess Espressif initially only consider using this library within their SPI flash scope, not for something bigger like SD cards.

BrianPugh commented

Hey guys, going to close this issue here as there's no real action items for this repo. You may continue the conversation if you'd like, however ๐Ÿ˜„

  • ๐Ÿ‘1
adokitkat commented

Meanwhile esp_partition is also usable, but needs quite a bit hacks. The size and address fields in esp_partition are all uint32_t which is limited to 4GB. I guess Espressif initially only consider using this library within their SPI flash scope, not for something bigger like SD cards.

Hello :) If you want to support large storage media or make something easier for you from our side, discussion and pull requests are welcome!

huming2207 commented

Hi @adokitkat thanks for your comment!

I will write up a feature request for now at ESP-IDF repo for further discussion about this. Meanwhile I'm busy working on something else so I'm afraid I don't have time at this stage for working on a PR.

  • ๐Ÿ‘1