jonahsnider/convert

Data `bigint` conversion error due to ratio is not an integer

carlocorradini opened this issue · 4 comments

carlocorradini commented

All data conversions fail if using bigint due to Conversion for [UNIT] to [UNIT] cannot be calculated as a BigInt because the conversion ratio is not an integer error. 
Even a simple operation like this fails:

convert(1024n, 'B').to('KiB');
jonahsnider commented

This is an issue that I'm aware of. When I'm free in a few days I can investigate if improving this is feasible. I'll also add that this isn't an issue for all conversions (ex. convert(20n, 'hours').to('minutes') works), but is a problem for many others.

carlocorradini commented

Thanks 🙏

carlocorradini commented

Hey, @jonahsnider any update? Thanks 🥳

jonahsnider commented

Sorry, I've been caught up with other things and I'm not sure when I'll have the time to look into this. I suspect that the fix is going to require a fair deal of work, which is not ideal as well.

  • 😕1