_ShaderSamplerBuilderLayer throws "Invalid image dimensions" if target has no size.
Closed this issue · 3 comments
gskinner commented
_ShaderSamplerBuilderLayer._buildChildScene
throws an "Invalid image dimensions" error if the target widget does not have a size, which is difficult to resolve in a number of scenarios.
I resolved this by checking the size at the top of _ShaderSamplerBuilderLayer.addToScene
:
void addToScene(ui.SceneBuilder builder) {
if (size.isEmpty) return;
// etc
Happy to submit a PR for this @jonahwilliams
jonahwilliams commented
Also good catch :)
gskinner commented
Want me to just package these as a single PR?
jonahwilliams commented
sure!