No icons in demo on chrome/windows 7
Closed this issue · 13 comments
In chrome/windows 7 the demo look different than the screenshot:
Thanks so much for reporting this. Generated SVGs can be fickle. Let me look into this and get back to you.
Confirming this on Chrome in Linux.
I misread the original issue. See comments below.
@jhpratt, @jcubic, are the icons working @ https://jonathantneal.github.io/media-player/ ?
That site runs off the gh-pages branch, which I’ve switched over to use the upcoming v1 version. If that works for you, I will release v1 immediately.
It's the RTL layout that shows like that for me. The page you linked to looks as expected.
@jhpratt, thanks for the fast response! To confirm, you are saying that the icons aren’t showing @ https://jonathantneal.github.io/media-player/rtl.html ?
@jonathantneal I'm seeing this. Not sure what's causing it.
(sorry, misread the original issue, but it's still something)
That looks right. That’s a right-to-left page translated into Hebrew to demonstrate how RTL is handled. Notice that the icons are also flipped.
The demo could be better, because I have the video player stacked atop the audio player, and that looks kind of weird. What issue are you having?
Ah, I assumed they were both for the video player. Do RTL languages use reversed icons? I didn't think so, but I also don't speak Arabic/Hebrew/etc.
I didn't test anything, just the visual :) Maybe it's not an issue at all!
@jhpratt, to be honest, I really expected them to be, based on what I saw going on with text, and how the play button points in the direction of the flow, but now I see this:
Just go for the normal left to right bar because its the norm on almost every player
—
https://www.reddit.com/r/learn_arabic/comments/4rk2po/designing_arabic_language_video_player_need_help/
And this
Do not mirror media playback or progress bars. The direction of these elements represents the direction of the tape, not the direction of time.
— https://material.io/guidelines/usability/bidirectionality.html#bidirectionality-localization
However, Material doesn’t show the play button, explicitly, so I’m not certain.
I’m asking on Twitter about RTL play controls and sliders.
@jonathantneal I looked at a couple Arabic sites for examples. Al Jazeera is of course based in the Middle East, while the others are not. However, none of them reverse the play symbol (or the volume, for that matter).
I think it's safe to say if native Arabic sites don't do it, that's not how it is. I've also sent a message out to a native Arabic speaker I know to see what they have to say.
Well, that just makes the player a lot easier. I’d like to get additional verification before I simplify the app even further.
This developer worked on Firefox OS:
People everywhere including MENA region used the same controls in CD players etc.. therefore it should be the same
— https://twitter.com/AhmedNefzaoui/status/902663005992824832
And in an article he wrote for Mozilla:
Please don’t RTL the media player buttons.
— https://hacks.mozilla.org/2015/09/building-rtl-aware-web-apps-and-websites-part-1/
So, the player is going to become even smaller. :) The language support still makes it international-safe, but it’s not as impressive to me. That’s okay. The goal is not to create clever software. It’s to create good software.