jondkinney/docusign_rest

Client.get_signers(...) does not handle signHereTabs

Closed this issue · 3 comments

When a document is uploaded, the user should be able to supply multiple signHereTabs. I'm not sure about what design pattern should be used here. the "signers" input can also contain an array of tabs, which can be iterated over to produce the json request. Alternatively, the Client can take in a developer crafted json string (since there are no special "/r/n" needed) and have the file locations specified separately in a second argument.

Hey jjwmui,

You're right, it doesn't currently support multiple tabs. Feel free to take a shot at the implementation if you can and I'll be happy to review it and merge your changes. I don't currently need multiple sign here tabs so I can't invest the time in expanding the implementation right now. Hopefully if you or someone else doesn't get to it I can add this feature sometime in the future though.

I'm not sure of your skill level, but there are plenty of examples in the client.rb file of how to abstract a loop through an array of hashes (the signers hash for example does this).

Thanks!

Okay I can definitely do that. I'll get it in in a few days.

@jjwmui well as it turns out it wasn't long before I needed this.

Check out this commit: e3b390b

I've pushed a new version of the gem, 0.0.9 and updated the Readme to help document how to specify multiple sign here tabs.

Hopefully this helps you out too!

Thanks,
-Jon