Latest code breaks all graphs
Closed this issue · 7 comments
I pulled down the latest master this morning and all my graphs broke. After a bunch of individual file copying, it seems build/index.js is the culprit. Once I revert to my previous version, graphs work. Process is repeatable.
I will look more into this later...hoping that somebody else has already seen and fixed this to save me some time.
Trying this now..
Just placed the latest graphene.min.js in an old dashboard to make sure - seems to be working properly.
Can you provide some more info? such as what kind of errors you get (for example, from the javascript console).
Hopefully I can lend a hand
Thanks
I see the same thing.
building [Total Notifications] index.js:12
Uncaught TypeError: Cannot call method 'split' of undefined index.js:12
getUrlParam index.js:12
(anonymous function) index.js:12
w.each.w.forEach index.js:8
(anonymous function) index.js:12
w.each.w.forEach index.js:8
Graphene.build index.js:12
(anonymous function) index.js:12
(anonymous function) example-dash.js:77
(anonymous function) example-dash.js:80
Port error: Could not establish connection. Receiving end does not exist. miscellaneous_bindings:236
chromeHidden.Port.dispatchOnDisconnect miscellaneous_bindings:236
Got it, might relate to a misbehaving pull request. I'll check it now and apply a fix soon.
Problem was related to a condition where your Graphite source url does not have a query string. Hope this commit helps.
@tomvachon @tempspace hope this fix helps? -thanks