Are these code right?
Opened this issue · 1 comments
zhaoyipeng commented
The 57-61 lines of tool_error.py are as follows
for tool in gyro_continuous:
if tool in self.em['codes']:
self.gyro_continuous = [] #set gyro_continuous to empty list
self.em['codes'].move_to_end(tool)
self.gyro_continuous.append(tool)
My question is why always set gyro_continuous to empty list before append tool into gyro_continuous
jonnymaserati commented
Hi @zhaoyipeng
Sorry for the delay, I don't really get time to maintain this code these days.
No, that code doesn't look right. I never really finished the gyro error models, mostly because there's little to no diagnostic data that I could find to verify them, but I added what I did to the library in the hope that someone would pick it up and finish it off - so PRs are welcome if you fancy fixing it?