Not updating status as failed in 2nd step of build chain
sommestad opened this issue · 3 comments
We have a setup with multiple configurations in a build chain:
- Commit stage
- Automated acceptance tests
When (1) is successful it updates the Github status (of the pull request under test) accordingly. However, if (2) fails it will not update the pull request's status, leaving it as "successful".
It's the same if (2) is successful too; the Github status box will remain unchanged and still show details from (1).
Is this by design, a bug or have I missed something in the configuration?
I though that the addition of contexts would resolve this issue, but haven't seen any effect of adding them (we have two contexts: "Commit Stage" and "Automated acceptance tests").
Running plugin version 0.5.90
Teamcity Professional 8.1 (build 29879)
We merged contexts support feature recently into the plugin, hope this would help you to distinguish statuses. Once you used it you should two different status icons. Do you?
Please check server logs for info from the plugins. There you should see reports on all status update attempts
Thanks for getting back, sorry I missed it completely. No, we're only getting a single status icon, and the text associated with the PR contains the details from the first step of our process ("Commit stage")...
Looking at the logs, I can't see any attempts to even run ChangeStatusUpdater from our step (2). Is there any other configuration that is needed for it to run? Our step (2) doesn't have a VCS root attached, for example (since it uses the artifact from (1)).
It seems like not having a VCS root on step (2) was the culprit here. We're now getting a properly updated status. However, Github isn't showing two icons in the commit listings, but I guess that's on them and not you.
Thanks for a great plugin!