jonnyzzz/TeamCity.Virtual

No not write 'error' in finally step

Opened this issue · 3 comments

Current log is

             [10:22:21][Step 5/5] docker: Terminating images (if needed)
             [10:22:21][docker] Executing command: docker kill teamcity_tJkCfFeZ97f6tJHLLKePbM4VAYXYaWS8 2>&1 || true
             [10:22:21][docker] Starting: /home/builduser/buildAgent/temp/agentTmp/custom_script1247262640453440513
             [10:22:21][docker] in directory: /home/builduser/buildAgent/work/dcfccd8c4beb0fd0
             [10:22:21][docker] Error: No such container: teamcity_tJkCfFeZ97f6tJHLLKePbM4VAYXYaWS8
             [10:22:21][docker] 2014/05/06 12:22:20 Error: failed to kill one or more containers
             [10:22:21][docker] Process exited with code 0

This makes build script contain 'error' that frighten end-users

Could use

if docker ps | grep 'teamcity-HASH' ; then 
  docker kill 'teamcity-HASH' 
fi
exit 0

||: is not request in this case

Got you point. Thanks!