Plugin run docker mandatory with --rm=true

Question

Plugin run docker mandatory with --rm=true

frenchcomp opened this issue 8 years ago · 3 comments

Hi,
We can not overload this parameter because it's forced into https://github.com/jonnyzzz/TeamCity.Virtual/blob/49c0bf3e0e361d878962b02423f26b827b0d282a/agent/src/com/jonnyzzz/teamcity/virtual/run/docker/DockerVM.java

Thanks.

Answer 1 · 2016-11-04T21:27:45.000Z

What is the reason to overload it? Could you please elaborate

Answer 2 · 2016-11-04T21:37:14.000Z

Sorry, my english is not very good. To keep the volume and changes between two executions to be faster in some integration. :)
Best regards

Answer 3 · 2016-11-04T21:38:43.000Z

Sounds reasonable. It's possible to add more code in the plugin to check of --rm=false is specified in args. Please feel free to provide a patch for that