Grid lines
jonocarroll opened this issue ยท 8 comments
jonocarroll commented
Removing minor axis lines!
-- https://twitter.com/foundinblank/status/1202246795889455104?s=20
foundinblank commented
Could be something like easy_remove_gridlines(minor = TRUE, major = TRUE)
jonocarroll commented
Which makes more sense to you?
easy_remove_x_gridlines(minor = TRUE, major = TRUE)
or
easy_remove_gridlines(minor_x = TRUE, major_x = TRUE)
or
easy_remove_x_minor_gridlines()
foundinblank commented
I'd err on the side of less functions with more parameters than more
functions w less parameters! So:
`easy_remove_gridlines(minor_x = TRUE, minor_y = TRUE, major_x = TRUE,
major_y = TRUE)`
thomas-neitmann commented
My suggestion would be to have these three functions:
easy_remove_x_gridlines(major = TRUE, minor = TRUE)
easy_remove_y_gridlines(major = TRUE, minor = TRUE)
easy_remove_xy_gridlines(major = TRUE, minor = TRUE)
or alternativelyeasy_remove_all_gridlines(major = TRUE, minor = TRUE)
jonocarroll commented
Sounds good - I'm fine with having lots of functions/aliases so both xy
and all
are fine by me.
thomas-neitmann commented
Awesome! You'll get another pull request soon ๐
jonocarroll commented
Completed via #45
foundinblank commented
This is awesome :)