jonthornton/Datepair.js

Changes end time when changing date

Closed this issue · 3 comments

espen commented

How to reproduce:

  1. Go to basic example at https://www.jonthornton.com/Datepair.js/

  2. Set start date to current date.

  3. Set time to 2:00am.

  4. Set end time to 5:00am.

  5. Change start date to yesterday. End date is changed to yesterday (as expected). End time is now changed from 5:00am to 3:00am.

Changing the date further does not change the end time.

espen commented

After some investigation it seems like this is an issue in https://github.com/jonthornton/jquery-timepicker/

I'm unable to replicate the issue when using jquery.timepicker 1.13.14. With any newer version I get the outcome in this issue.

jonthornton commented

@espen you're correct, there was an event bubbling bug in jquery.timepicker jonthornton/jquery-timepicker@0873fe4

It should be fixed now.

  • 🎉1
espen commented

New version works perfectly. Thanks @jonthornton 🙏