Please freeze the page when the animated gif is displayed
Closed this issue · 4 comments
Whenever the joomla logo is displayed an overlay is also rendered BUT the page can still be scrolled
The effect is painful for the eyes.
Suggestion
Add a css style
body.modal-open {
overflow: hidden;
-ms-overflow-style: none;
}
And these two lines of javascript in the relevant places e.g. init ajax, onSuccess
$('body').addClass('modal-open');
$('body').removeClass('modal-open');
This will freeze the page and will be much better
Just as a reminder this code comes from joomla/joomla-cms#6964
which is RTC and most probably will make it to 3.4.2 so maybe the css styling won’t be necessary
Thanks
+1 although as this is going to support old 3.x versions of Joomla as well I guess we should add in the CSS
@wilsonge is right here. Always declare that class, if it already exists (e.g. >3.4.2) it will just override itself (same code)!
Good idea, PR welcome 👍 .
However, please preferably use a separate prefixed name for the class, so that we don't collide with Joomla base classes. ;-)