joomla-extensions/install-from-web-client

Install the install from web fails to load on page load

PhilETaylor opened this issue · 17 comments

Install from github joomla-cms master at revision 351b778254893d1ebbd734a88e3ad2a33b386aff

Login to admin

Install the install from web with the button provided

see that it fails to load the content all the time

screen shot 2016-12-11 at 15 28 57

To make it load this correctly you can click another tab and then click the Install from web tab

screen shot 2016-12-11 at 15 32 04

Cross posted to joomla/joomla-cms#13165

still an issue in 3.7.0 beta 1

@beat any clue why that happens? Looks like some JavaScript issue to me but I have no clue.

Maybe @DGT41 or @Fedik have an idea as well.

This is still an issue in 3.7b3

screen shot 2017-02-27 at 20 57 26

The problem is that

apps_installfromon = 0,

which stops the tab loading.

This is because apps_installfrom_url = '', because this method

is not returning anything correct.

Fedik commented

easy, you just need to click on "Install from Web" tab :neckbeard:

well, the script do not expect that "Install from Web" tab can be the first, so it waiting for the "click" in webinstaller.php#L103

easy, you just need to click on "Install from Web" tab

The tab is already focused and so should initialise on page load - this is the user experience we are aiming for here, rather than have them click away and then click back to the tab.

joomla_install
The problem is worse than just clicking on the tab. As of about two weeks ago it says that there are no extensions for your joomla version. 3.6.5

Yes, some day is ok, some day not, some category are ok some not...

I can test when there is a patch

beat commented

There is probably a simple Javascript fix to be made, which is the only correct fix for this.

I'm currently travelling. If someone can submit a PR in next 3-4 days, then someone can test it and we can then merge it.

Next week, "I'll be back" :-) so if there is hopefully a PR to fix the JS issue, I'll be able to look into it, and merge and release. If not, I'll take the time to fix it in time for 3.7 release, as I'm considering this a high priority issue.

Have a great week-end!

A clean install of Joomla v3.6.5 is still showing this problem.
Upon installing, it just keeps spinning the "Loading" icon. After clicking on a different tab and coming back to the "Install from Web" I end up getting the error message that says

Can't connect to the Joomla! server. Please try again later.

Any idea when this is going to be fixed?

Hello @beat , do you find the time to fix it in time for 3.7 release ?

Regards

beat commented

A new testing server is in place implementing joomla/install-from-web-server#36 and should fix the caching issues, thanks @mbabker !

It does not fix the initial load issue which is most probably client-side JS issue probably related with markup-changes in tabs.

Activation + Testing instructions: joomla/install-from-web-server#36 (comment) + joomla/install-from-web-server#36

It does not fix the initial load issue which is most probably client-side JS issue probably related with markup-changes in tabs.

If it's related to client side, then it is really an old bug as it is already present in 3.6.5. Probably even older then since both 3.6.4 and 3.6.5 were only security releases.

beat commented

@Bakual bug is due to a B/C break at some point, it's not important to know exactly when, but to find why and to fix it.

First investigations show that it's in addition loading-timing dependent, as it doesn't happen each time.

Please test this PR #52