[4.0] param show_cat_num_links_cat or show_cat_num_links ?
chmst opened this issue · 4 comments
Steps to reproduce the issue
param for number of links is set but not displayed
Expected result
Number of links is shown in view categories
Actual result
Number is missing
System information (as much as possible)
Additional comments
Guess it causes by your copy/paste error while working on the layout. Could you please check and confirm this commit 8aa92f9 fixed it?
https://github.com/joomla-extensions/weblinks/blob/master/src/administrator/components/com_weblinks/config.xml#L316 it was caused from here. The two models for category and categies use different filters. So we should decide which name we use everywhere.
The Categories model should use show_cat_num_links_cat parameter. The Category model will use show_cat_num_links parameter. That's same with how other core components work.
Could you please check and confirm this commit 8aa92f9 fixed it?
I have check and for me it fix it for the weblinks-categories-view. Thank you.
In the weblinks-category-view is the same problem because at
https://github.com/joomla-extensions/weblinks/blob/4.0-dev/src/components/com_weblinks/tmpl/category/default_children.php#L40
there is no code to display number of links as in joomla 3 Weblinks at:
My example:
<?php if ($this->params->get('show_cat_num_links') == 1) :?> <span class="weblink-count badge bg-info"> <?php echo JText::_('COM_WEBLINKS_NUM'); ?> <?php echo $child->numitems; ?> </span> <?php endif; ?>
or with other classes and html-tag.