joomla-extensions/weblinks

Division Not Closed in a /mod_weblinks/tmpl/ File

cmbr opened this issue · 8 comments

cmbr commented

A closing HTML division tag is missing from the /modules/mod_weblinks/tmpl/default.php file in the 4.0-dev branch.
The division with the classes d-flex and flex-wrap opens at or near line 59 but is never closed.

Steps to reproduce the issue

To test, create a module using this extension in a Joomla 4.3.3 website. Include at least one weblink. The web page on which it is displayed will not pass an HTML validator. For each weblink displayed, the validator will report two errors:
Error: End tag li seen, but there were open elements.
Error: Unclosed element div.

Additional comments

The solution is to add a </div> tag just before the </li> tag at or near line 183 of the /modules/mod_weblinks/tmpl/default.php file.

alikon commented

@cmbr can you submit a pull request ?

cmbr commented

Yes, as soon as someone makes me a collaborator here. My attempt at creating a pull request was blocked.

Hackwar commented

I'll have a look in the settings tomorrow, but you should be able to open a PR as a random GitHub user.

cmbr commented

Upon submission of the pull request, the message I receive is Pull request creation failed. Validation failed: must be a collaborator.

HLeithner commented

Hi @cmbr based on SE it seems there is a problem with your account, you might want to contact the github support?

cmbr commented

Thank you for the suggestion. I've tried a few approaches without success. In any case, I have attached the text of my pull request for use by any authorized collaborator here.
Pull Request for Issue 533.txt

alikon commented

i've made #534 following your findings

p.s.
i hope you'll solve you gh account issue soon

thanks

Hackwar commented

Since the PR has been merged, I'm closing this one.