visual-fill-column breaks horizontal window splitting on emacs 25

Question

visual-fill-column breaks horizontal window splitting on emacs 25

glyph opened this issue 9 years ago · 10 comments

I'm using Emacs 25.0.50.1.

Start emacs.
M-x visual-fill-column-mode
C-x 3

I would expect the window to split vertically; instead, I get split-window: Window #<window 3 on *scratch*> too small for splitting (2).

As I recall this worked at some point either on an earlier version of Emacs or an earlier version of visual-fill-column.

glyph commented 9 years ago

Thanks!

Answer 1 · 2016-01-17T07:53:57.000Z

Yeah, just confirmed that it works fine on GNU Emacs 24.5.1, so this is only a bug in unreleased versions of Emacs. So it's probably an emacs issue. But I don't know how to report it in emacs, so hopefully with better knowledge of visual-fill-column you can write up a bug report for them before they cut the next release :)

Answer 2 · 2016-01-18T08:44:49.000Z

Yeah, something seems to have changed... I'll investigate and see what I can find out.

Answer 3 · 2016-01-19T08:10:35.000Z

Do you happen to know when you last updated your Emacs sources before this problem appeared? I'm looking for the last commit where window splitting still worked.

Answer 4 · 2016-01-19T08:13:41.000Z

Unfortunately I don't update in small increments. Pretty sure I had a build from the beginning of December that didn't have this problem, but I don't think I can be more granular than that. Sorry, thanks for investigating this, and good luck!

Answer 5 · 2016-01-27T10:05:35.000Z

I found the commit that is responsible for this change and asked on emacs-devel. Apparently, it is a planned change, so this is going to be the default behaviour in the next version. I was given some suggestions on how to deal with this on the list, but I haven't gotten round to implementing one yet. I'll post an update here when I do.

Answer 6 · 2016-01-27T19:40:28.000Z

@joostkremers bummer! I hope you can figure something out before the release, writeroom-mode is one of my favorite emacs packages :)

Answer 7 · 2016-02-24T21:47:06.000Z

I've implemented the suggested fix, and it seems to work. Please try it and let me know if you run into any problems.

Answer 8 · 2016-09-30T18:44:30.000Z

@joostkremers Just wanted to follow up and say: yes, it seems to work great, I've been using various versions and platforms of Emacs 25 for a while, and it seems like everything's working smoothly when I invoke writeroom-mode :)

Answer 9 · 2016-10-02T20:43:08.000Z

Thanks for letting me know. Glad to hear it's working fine. :