Default exports break down in converted CJS version

Question

Default exports break down in converted CJS version

kibertoad opened this issue 3 years ago · 4 comments

kibertoad commented 3 years ago

See pinojs/pino-pretty#237

process["default"].env is definitely incorrect. Looks like we should avoid using default imports here.

Answer 1 · 2021-09-22T19:15:57.000Z

@jorgebucaran Wonder if we could be running CI on built CJS version somehow.

Answer 2 · 2021-09-22T19:16:43.000Z

Duplicate of #73

Answer 3 · 2021-09-23T01:11:42.000Z

Should be possible, let me check the docs.

Answer 4 · 2021-09-23T18:10:01.000Z

@kibertoad Sorry, looking into your comment again, I'm not sure exactly what you mean. The CI runs the tests. We could look into adding a special test just for the CJS version, though. That what you were thinking?