jorgebucaran/fishtape

test vs tests for directory name

PatrickF1 opened this issue · 5 comments

PatrickF1 commented

Hi Jorge, sorry if this is a bit too nit-picky, but I was wondering on your thoughts on whether plugins that use fishtape should put their tests in a dir called test or tests? I was thinking tests since all the other traditional fish files are plural (functions, completions, fish_plugins, fish_variables). However, in this plugin you called it test. Now I'm not sure what the consensus is. What do you think?

jorgebucaran commented

Good question. I prefer test and use it everywhere, not just in Fish.

But this is probably a convention I carried over from the JavaScript world, which is irrelevant in Fish. I'm willing to change everything to tests if we can make a good argument for it.

  • Many fish files are plural: functions, completions, fish_plugins, fish_variables.
  • Fish uses tests.
  • Tide, Pure, Spacefish, Fzf.fish use tests.

What else do you have?

  • 👍1
PatrickF1 commented

Have you done a broad survey of fish plugins with tests to see what they've done? I'm assuming you have so know more than me. The only other plugin I've found not written by you that uses Fishtape is by Tide, and Ilan uses tests. See https://github.com/IlanCosman/tide/tree/main/functions/tide/tests

jorgebucaran commented

Pure and Spacefish use Fishtape as well (not the latest yet, though), and they all use tests, not test too.

PatrickF1 commented

Well, there's my argument then. I'm going to use tests for now but can be convinced to change if other people change too. Thanks Jorge!

  • 👍1
jorgebucaran commented

Good enough for me! 🙌