jorgebucaran/hydro

Symbol issues

kidonng opened this issue · 3 comments

  • Mode prompt lacking symbol for replace mode, which is presented in Fish's default mode prompt, is this intended?
  • Pipestatus separator ǀ doesn't look good with JetBrains Mono on kitty, can this be changed to standard | or made configurable?
    image
    EDIT: looks like this is already reported in #15

Mode prompt lacking symbol for replace mode, which is presented in Fish's default mode prompt, is this intended?

I'm not really sure. Maybe there's a bug in

function fish_mode_prompt
if test "$fish_key_bindings" != fish_default_key_bindings
set --local vi_mode_color
set --local vi_mode_symbol
switch $fish_bind_mode
case default
set vi_mode_color (set_color $fish_color_selection)
set vi_mode_symbol N
case insert
set vi_mode_color (set_color $fish_color_selection)
set vi_mode_symbol I
case replace_one
set vi_mode_color (set_color --reverse $fish_color_selection)
set vi_mode_symbol R
case visual
set vi_mode_color (set_color --reverse $fish_color_selection)
set vi_mode_symbol V
end
string unescape "$vi_mode_color $vi_mode_symbol \x1b[0m "
end
end

Pipestatus separator ǀ doesn't look good with JetBrains Mono on kitty...

Making the pipe symbol configurable sounds reasonable.

Mode prompt lacking symbol for replace mode, which is presented in Fish's default mode prompt, is this intended?

I'm not really sure. Maybe there's a bug in

function fish_mode_prompt
if test "$fish_key_bindings" != fish_default_key_bindings
set --local vi_mode_color
set --local vi_mode_symbol
switch $fish_bind_mode
case default
set vi_mode_color (set_color $fish_color_selection)
set vi_mode_symbol N
case insert
set vi_mode_color (set_color $fish_color_selection)
set vi_mode_symbol I
case replace_one
set vi_mode_color (set_color --reverse $fish_color_selection)
set vi_mode_symbol R
case visual
set vi_mode_color (set_color --reverse $fish_color_selection)
set vi_mode_symbol V
end
string unescape "$vi_mode_color $vi_mode_symbol \x1b[0m "
end
end

Maybe

- case replace_one
+ case replace replace_one

If you are a vi mode user and this works for you, please send me a PR.