jorgebucaran/hyperapp

Issue with null-vnodes

zaceno opened this issue · 1 comments

zaceno commented

Apparently it is possible, although I don't yet know how, to reach line 234:

hyperapp/index.js

Line 234 in d6e0704

if ((oldKey = oldVKids[i].key) != null) {

with an oldVKids[i] that is actually null. When that happens, a runtime error occurs.

I haven't been able to reproduce it in a simple, shareable example but I have seen it happen. And as far as I know null is an acceptable entry in a children-array (as is anything falsy) so we should ensure that we either do not reach that point with a null-child, or somehow handle the fact that it can be null.

And it would be really cool if someone can come up with a simple example demonstrating how to cause this bug.

zaceno commented

Let's close this one. I haven't yet been able to reproduce it.