josedonizetti/ruby-duration

miliseconds

benlieb opened this issue · 6 comments

benlieb commented

Di you plan on implementing miliseconds? I started using this for an ffmpeg video editing project, and a lot can happen in a second on film. Ffmpeg has a function that tells you where a video fades to black at say at second 3535.3432. I wanted to store and manipulate these as Duration objects, but it's just not fine grained enough. Seem like a useful thing to have.

Any thoughts?

benlieb commented

I've come back to check on this. If I submitted a pull request would you be interested in this functionality?

peleteiro commented

Not really. Adding microseconds would make this incompatible with ISO_8601.

pkaeding commented

I'm curious how supporting milliseconds would break compatibility with ISO 8601 durations? From the Wikipedia article linked above:

The smallest value used may also have a decimal fraction, as in "P0.5Y" to indicate half a year.

Thus, 237ms could be expressed in a ISO 8601-compatible format as P0.237S.

peleteiro commented

My mistake, you're right.
I'm fine with microseconds. You can submit the PR.

benlieb commented

I've come come back again to check on this, haha. But I guess neither I nor anyone else has had the time to implement micro / milliseconds. :(

peleteiro commented

I don't use ruby either this lib anymore. If someone else wants to implement microseconds and/or take over the project let me know.