josegonzalez/cakephp-queuesadilla

queue Shell param not passed to worker

robertscherer opened this issue · 5 comments

robertscherer commented

I'm not sure if this is a bug or a misunderstanding on my part.

I have configured a default config using the MysqlEngine and am running the shell using the following command:

bin/cake queuesadilla --config default --queue email

The Jobs queued for the email queue are not performed. Is this a wanted behavior?

Thanks

josegonzalez commented

It should be overriding it here. What is the output of the logger?

robertscherer commented

The output of the logger is just "No job".

I have debugged it and found that the queue param value is "default" in the Worker instance (this is a protected property called $queue in josegonzalez\Queuesadilla\Worker\Base.

I think we just need to pass the parameter to the Worker's constructor in QueuesadillaShell::getWorker().

But I'm not clear about the architecture related to the fact that both the engine and the worker would need the queue param.

josegonzalez commented

You can override the engine's queue when using an engine, so this makes sense. I just verified the issue and will push a fix out.

josegonzalez commented

Closed by bb95ca1.

josegonzalez commented

Released in 0.3.3.