PHP 8.x compatibility.
kevindecapite opened this issue · 2 comments
kevindecapite commented
Would you accept a PR that removes deprecations for PHP 8.x?
bin/cake worker --queue ephemeris
2023-03-31 00:51:16 info: Starting worker
2023-03-31 00:51:16 notice: Return type of josegonzalez\Queuesadilla\Job\Base::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
I'm happy to give it a go although I suspect there may be other issues other than this one in making the library fully compatible with 8.x?
josegonzalez commented
Pull requests welcome, but if you're using a recent version of CakePHP, I recommend the official Queue plugin (which was inspired by this repository).
kevindecapite commented
Thanks for the reply. That's exactly what I did. I'll close this issue.