josegonzalez/php-git

Directories with dot characters in them fail (such as .git directories)

Closed this issue · 6 comments

eriknyk commented

mi repos directory have names with dot '.' example my_repo.git, and never works for me

josegonzalez commented

Do you have a patch?

josegonzalez commented

I believe this has to do with sanitization of urls to ensure people don't try to traverse directories. I'll take a look at this later this weekend if no one else will ;)

lxfontes commented

Going through each entry in config/routes.php and changing:

  •   array('project' => '[\w_-]+')

  •   array('project' => '[\w_-]+(.git)?')

did the trick for me.
(edit: github doesn't seem to like regexes :) .git has a backslash)

josegonzalez commented

Pull request? :)

lxfontes commented

seems there's is some extra work required on Git::blob in order to show the file contents properly. will try to get that going.
Something along the lines: https://gist.github.com/1503192
this would require an PECL extension ( finfo ) to determine the mime type, but I rather not add any dependencies to the code.

josegonzalez commented

I'm no longer maintaining this repository. Pull requests welcome, but I won't be fixing any issues.