joseluisq/gitnow

Extend tag command for annotated Tags

lukasgierth opened this issue · 3 comments

lukasgierth commented

Would it be useful to add the -a flag optional to the tag command to create the SemVer Tag as an annotated tag?

joseluisq commented

Sure, maybe adding a -a --annotate to the tag flags list.

lukasgierth commented

You want to use -a in the not yet implemented --premajor, so that would be a naming conflict. Which should we rename?

I created a pull request, that uses a quite generic implementation so we could add other arguments later on.

joseluisq commented

You want to use -a in the not yet implemented --premajor, so that would be a naming conflict. Which should we rename?

I created a pull request, that uses a quite generic implementation so we could add other arguments later on.

It's not really a problem since --premajor is not implemented yet and it could be changed to something else if needed.