josephburnett/jd

Return code is always 1 in version 1.7.0

dreedarm opened this issue · 1 comments

dreedarm commented

With version 1.7.0 I'm finding that the return code is always being set to 1 even if the files match.

10:48 $ jd --version
jd version 1.7.0
10:48 $ jd --set expected_output.json expected_output.json
10:49 $ echo $?
1

With previous version this would return 0 and 1 only when the input files differed.

josephburnett commented

Whoops! Sorry about that. When I added support for using jd as a git diff driver, I accidentally dropped a line: c79c2ec

I've fixed this bug and added main tests to make sure it never happens again: b5d115c

The latest release 1.7.1 has this bug fix: https://github.com/josephburnett/jd/releases/tag/v1.7.1

  • 👍1