joshday/OnlineStatsBase.jl

Extrema() only available for Date time types

brucala opened this issue · 1 comments

extrema_init(T::Type{Date}) = typemax(Date), typemin(Date), Union{Date, Dates.AbstractDateTime}

As I understand from the code above, it looks like Extrema() only works for Date time types. Is there a reason for not extending to a generic TimeType?
For instance replacing the code to something like:

extrema_init(T::Type{<:TimeType}) = typemax(T), typemin(T), TimeType

Is there a reason for not extending to a generic TimeType?

Only that my use case was for Date when I was implementing it.

Fixed on master! New release pending. Thanks for the issue!