joshfraser/PHP-Name-Parser

Doesn't work properly for names with degrees

Closed this issue · 4 comments

TomThak commented

Hello,
if I use it for parsing names with education degrees it doesnt work.

For example:

"Ing. Jan Novák Csc."

atla5 commented

@TomThak do you know where I could find a listing of 'Ing.' and 'Csc.' -style "education degrees" or could you otherwise provide one? I've not seen either of those before.

(just know about MD, PhD, Master, Prof.)

TomThak commented

Yes, it is Czech Republic, Slovakia degrees.

https://cs.wikipedia.org/wiki/Akademick%C3%BD_titul

The 1st column of the 1st table means, all the degrees before name, the 2nd table 1st coll means titles after name (academical degrees).

  • 👍1
atla5 commented

@TomThak, @joshfraser: I just completed and sent along a suggested addition to parser.php for a bunch of those other prefixes.

I took the new items from eric willis's listing that I found online, and from the wikipedia article TomThak provided.

@TomThak since the english version of the article had different content and phrasing, I had to run the czech version through google translate. if you would look through my suggested edit and check that there aren't any mistakes, I'd appreciate it.

@joshfraser not knowing how you wanted to document the changes to the file, I added a brief description to the class header that you can feel free to re/move if desired.

joshfraser commented

thanks everyone for getting this done. merged.