[0.3.2] window is not defined

Question

[0.3.2] window is not defined

gpoitch opened this issue 7 years ago · 7 comments

I know this is only meant to be used in a browser, but it's convenient when running tests that this package can be safely imported.

Since upgrading from 0.3.1 -> 0.3.2, I get a window is not defined error coming from this package. It looks to be from the bundling code. Might have to configure webpack to use libraryTarget: "umd"?

Answer 1 · 2018-03-14T17:04:51.000Z

I did change the webpack config in 0.3.2. Do you have a sample repo I can test against?

Answer 2 · 2018-03-14T17:15:18.000Z

Thanks for looking. No I don't have an accessible repo. I can just PR a fix when I get a moment.

Answer 3 · 2018-03-15T17:58:30.000Z

I just pushed a beta for 0.3.3 to NPM, let me know if that fixes it and I'll cut a proper release.

Answer 4 · 2018-03-19T15:08:07.000Z

Same issue in 0.3.3-0

Answer 5 · 2018-03-19T16:49:03.000Z

I have to admit I don't know what's going on, then. Happy to dig in more if you can send me a minimal reproduction, or a PR when you have a chance.

Answer 6 · 2018-03-19T18:50:58.000Z

Here is a failing test: https://github.com/joshfrench/react-mobiledoc-editor/compare/master...gpoitch:umd-fail?expand=1

Looks like a new issue with webpack: webpack/webpack#6784

Answer 7 · 2018-03-19T20:35:31.000Z

Thanks for digging! I'll get a patch out and hold off on webpack 4 until that's fixed.