joshfrench/react-mobiledoc-editor

RFC: Change build pipeline

malcolm-kee opened this issue · 3 comments

malcolm-kee commented

I would like to propose the following changes to the build pipelines:

  • Change from npm to pnpm as the package manager for this project, which has great monorepo supports.
  • Use rollup to generate the output for this project with commonjs, umd, and esm format, which allow the consumer choose which ever most optimal for them, e.g. esm format is most optimal for bundler to perform treeshaking
  • Demo will be using the built output (which would reflect closer to how the library user use it), and will be deployed to Netlify (or other hosting platforms) as part of the CI, to allow interested developers to play with it.

Any objections before I proceed to do the changes above? @joshfrench

joshfrench commented

As I said, I don't really use this anymore so I'm speaking in my role as an open-source steward of this project and not someone with a technical interest here, but my preference would be to keep the tooling simple. I would like it if this project was just as easy for the next person to contribute to -- regardless of their level of experience.

I do like the idea of a demo server though! Is that something we can do without changing the build tooling? (And without paying for?)

malcolm-kee commented

@joshfrench yeah it's possible. Will tag you for review when my PR is ready.

malcolm-kee commented

resolved with #91