joshk/completeness-fu

please make sure ActiveModel::Naming is included....?

angelacode opened this issue · 6 comments

angelacode commented

I get the following error:
please make sure ActiveModel::Naming is included so completeness_scoring can translate messages correctly (CompletenessFu::CompletenessFuError)

I'm not sure what that means or what to do. I am in Rails 3.0.0

joshk commented

Hi @Anglecode,

I have fixed the issue, which was a bug, well, poor programming tbh.

I was including the ActiveModel::Naming module into my class I was using for testing, and checking if the module was included, when really if I had checked the docs for AM::N I would have seen it needs to be extended into the class.

This should now work on master. If you are able to test this code and confirm it works I will release a new gem.

Thanks a bundle for reporting this issue, and sorry about the delay in replying :/

Josh

pmoran commented

I can confirm this is working on master (with Rails 3.1.0.rc4). Nice work!

angelacode commented

how can I check this, can I use with bundle or do I need to do something else?

angelacode commented

I just set Gemfile :git => to your git file and did a bundle update, hopefully that's right if not, let me know...

pmoran commented

Yes. I was able to set my Gemfile to use master via:
gem 'completeness-fu', :git => "git://github.com/joshk/completeness-fu.git"

patrickalgrim commented

It's definitely solved when using your github account for the gem. You should release a new gem, this is a fantastic resource!