jpardogo/PagerSlidingTabStrip

Bug when the indicator line, underline and dividers are drawn

Closed this issue · 2 comments

I think there is an error when the indicator line, underline and dividers are drawn.
The order in which draw is wrong.

Current order:

  1. Indicator line
  2. Underline
  3. Dividers

The problems are:

  • The dividers are drew above the underline.
  • The underline is drew above the indicator line, and indicator is not visible.

I consider correct this order:

  1. Dividers
  2. Underline
  3. Indicator line

Pager configuration in activity_main.xml:

<com.astuetz.PagerSlidingTabStrip
        android:id="@+id/tabs"
        android:layout_width="match_parent"
        android:layout_height="?attr/actionBarSize"
        android:background="?attr/colorPrimary"
        app:pstsUnderlineColor="#FF0000"
        app:pstsUnderlineHeight="6dp"
        app:pstsIndicatorHeight="6dp"
        app:pstsDividerWidth="6dp"
        app:pstsDividerColor="#0000FF"
        app:pstsTabPaddingLeftRight="10dp" />
  • Current screenshot
    screenshot_2015-02-17-00-53-25
  • My pull request:
    screenshot_2015-02-17-00-54-12

Yeah that make sense

PR associate #96 has been merged in dev branch for next release