jpbede/pydiscovergy

Allow install on Python 3.12

cdce8p opened this issue · 2 comments

cdce8p commented

The package requirements don't allow installs on 3.12 currently. That prohibits testing for applications that depend on this package, like Home Assistant. In general, it's better for libraries to keep their dependencies as open as possible for downstream apps to be able to resolve dependency conflicts. I would recommend >=3.9 here.

python = ">=3.9, <3.12"

--
As a side note, since I saw the discussion about the authlib pin, if the library is compatible with both <1.0 and >=1.0, it's usually better to use something like >=0.15. Once all other dependency are ready to upgrade and open up their respective pins, the authlib update will happen automatically.

authlib = "<1.0.0"

cdce8p commented

Opened #79 to update the authlib requirement.

For Python, dataclasses-json needs to be updated first. Opened lidatong/dataclasses-json#449 for that. Once a new version is released, it can open a PR here to update it as well.

jpbede commented

Thanks a lot. I've merged the authlib requirement. I'm now waiting for dataclasses-json before I create a new release.