Too many panics/unwraps in the wrong places
Closed this issue · 1 comments
jpeddicord commented
I'd like to remove most .unwrap
calls where reasonable. The code doesn't crash* in normal operation, but when given invalid input it happily panics. That's bad.
*that I know of
jpeddicord commented
I'm a lot more comfortable with the state of things now. There are still a bunch of unwraps, but they're used in places where, barring future logic errors, a value will always be present.
Will re-evaluate in the future.