Suggestion: Reply with comment with the slash command result
carolynvs opened this issue · 4 comments
As I was implementing OWNERS file support, I noticed that from the commenter's perspective it's not always clear when the command failed, and where to see what happened. Other github bots will usually reply back when it can't execute the command or tells you what it did on your behalf.
What if we had the bot post back if the commenter isn't authorized to run that command, or the result of what the action did (e.g. added a label)? I'm not sure if chattiness is a problem but it seems like this would help users quickly know how their command worked out.
carolynvs: /lgtm
prow: Cannot apply the lgtm label because @carolynvs is not in the reviewers role in the OWNERS file
carolynvs: /lgtm
prow: Added lgtm label
subsequent /lgtm commands won't print anything because the label is already applied
carolynvs: /lgtm cancel
prow: Removed lgtm label
carolynvs: /approve
prow: The pull request was approved by @carolynvs
It could be annoying to get an extra notification for each slash command though. We could just reply with errors and otherwise people can assume it worked if they don't hear back?
It could be annoying to get an extra notification for each slash command though. We could just reply with errors and otherwise people can assume it worked if they don't hear back?
Hmmm great thought. Yeah, I'm thinking the default user experience should be "it just works TM" and they won't see an error notification nor message unless there is a failure.
could it edit the original message with a bot reply? maybe that wouldn't trigger notifications and would keep it clean