jpsim/CardsAgainst

White card text not visible when dark mode is enabled

jayson528 opened this issue · 4 comments

Hey, i noticed that the WhiteCard text is not visible when dark mode is enabled in iOS 13. The label textColor for the WhiteCards was never set, so by default it will turn white with dark mode enabled.

Im going to submit a PR for the fix in about 5 minutes.

Dark mode disabled:
image

Dark mode enabled:
image

jpsim commented

I'm amazed someone out there is still running this 😆

To be completely honest with you i'm doing these for school and i was trying to replicate the other bugs and by complete accident stumbled upon it. Do you mind if i make a separate PR to fix the constraints to fit the iPhone 10 display? @jpsim

jpsim commented

That'd be great, thanks for your help.

jpsim commented

Fixed in #17.