jrconlin/pushgo

setup.sh without $goroot set will copy entire '/' dir into root/

Closed this issue · 2 comments

edwindotcom commented

setup.sh without $goroot set will copy entire '/' dir into root/

  1. make sure you don't have goroot set
  2. run ./setup.sh
    result: it starts to try and copy / into root/

expected: it shouldn't be that easy to make this faux pas

andreapavoni commented

there isn't a setup.sh anymore. perhaps this issue should be closed ;-)

jrconlin commented

Yep, setup.sh was removed in favor of the equally temporary install.bash.

I'm still investigating what the right install procedure is for packages like this. I tend to prefer Makefile because I'm old school. The Go authors seem to prefer separate script files.