jreinke/magento-admin-theme

Button background not showing

Opened this issue · 1 comments

On Magento 1.5.1, the background for buttons doesn't appear correctly. The issue is because the button html is setup as

<button><span>Button Text</span></button>

instead of

<button><span><span>Button Text</span></span></button>

I've fixed this issue by updating lines 524-532 of boxes.css to

button { overflow:visible; width:auto; border:0; padding:0 4px 0 0; margin:0 8px 0 2px; background:transparent url(images/bkg_btn.png) 100% 0 no-repeat; cursor:pointer; }
button span { float:left; height:28px; background:transparent url(images/bkg_btn.png) 0 0 no-repeat; padding:0 0 0 8px; font:bold 12px/27px Tahoma, Verdana, Arial, sans-serif; text-align:center; white-space:nowrap; color:#f15a24; position:relative; right:4px; }

button:not(.disabled):hover { background-position:100% -70px; }
button:not(.disabled):hover > span { background-position:0 -70px; }
button:not(.disabled):active { position:relative; bottom:-1px; right:-1px; }

I haven't tested it too thoroughly. I haven't seen any problems yet though, so I think it should be good.

Thanks for bug and fix report.
Could you make a PR for this?