jrgarciadev/react-iconly

Some icons are missing/extra

hiradary opened this issue ยท 7 comments

Iconly is a set of 500 icons (100 icons in 5 different styles). However, if you count the number of icons here:

https://react-iconly.jrgarciadev.com/

You'll see 101 icons. One icon seems to be extra.

Also, if you see the official list here, you'll see the below icon which isn't listed on react-iconly page:

Screen Shot 2020-12-29 at 5 23 33 PM

Screen Shot 2020-12-29 at 5 31 11 PM

I think there are inconsistencies between the actual icon set and react-iconly, which is something quite important to fix.
I guess we should go through the icons one by one, to ensure there's no inconsistency between the two.

Hey @hiradary, it's listed with the Chevron Down name in the bold category.

Screen Shot 2020-12-29 at 18 07 32

One icon is extra because I added the "Heart" icon without inner line.
Screen Shot 2020-12-29 at 18 14 37

@jrgarciadev Got it!

There's one more thing to mention. We've got PaperFail and ShieldFail icons. It's mistakenly written as PaperFall in mapIcons.js file.

PaperFall: IconPack.PaperFall,

ShieldFall: IconPack.ShieldFall,

The correct form is used in the website:

"ShieldFail": ["shield", "fail", "insecure"],

"PaperFail": ["paper", "document", "file", "fail"],

Hi @hiradary thanks for reporting, I already rename it here -> fc70b86

@jrgarciadev I found another issue on the website...

if you visit here and select different sets such as two-tone and light, you'll see some sets contain less/more icons compared to the other ones. Whereas in the official pack, all sets contain 100 icons, nothing more or less. Here we should see 101 icons - considering the fact that you added another heart Icon.

@hiradary Thanks for reporting, I'm going to review the icons map generator script https://github.com/jrgarciadev/react-iconly/blob/main/website/scripts/generate-icons.js

Hi! @hiradary

The missing icons were solved, it was a problem with the names that did not allow the generate-icons.js script to generate them correctly, for example in website/icons/light there was the icon "TicketStart" with the name "Ticket Star.svg" with space.

Also, I updated these icons on Algolia

Here the changes -> 9a94cbf

@jrgarciadev Great! Thanks.