jrgerber/smbios-lib

SMBiosVersion is difficult to use.

Closed this issue · 0 comments

This code is clumsy looking because SMBiosVersion does not have a new method and it does not derive a Copy trait. Add those.

                            let two_six_version = &SMBiosVersion {
                                major: 2,
                                minor: 6,
                                revision: 0,
                            };
                            if let Some(version) = &smbios_data.version {
                                if version < two_six_version {
                                    let p = val.raw;
                                    println!("{:02X}{:02X}{:02X}{:02X}-{:02X}{:02X}-{:02X}{:02X}-{:02X}{:02X}-{:02X}{:02X}{:02X}{:02X}{:02X}{:02X}", 
                                    p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7], p[8], p[9], p[10], p[11], p[12], p[13], p[14], p[15]);
                                } else {
                                    println!("{}", val);
                                }
                            } else {
                                println!("{}", val);
                            }