Missing Defaults Values $settings for \linfo\linfo

Question

Missing Defaults Values $settings for \linfo\linfo

Opened this issue 8 years ago · 2 comments

KTP95 commented 8 years ago

$linfo = new \Linfo\Linfo; --> create problem without $setting vars,

Maybe possible do a defaults values and hard-include it in the class...

Answer 1 · 2017-04-23T19:52:03.000Z

That would be a good idea. Feel free to make a PR.

Answer 2 · 2017-04-23T20:59:45.000Z

I'm not 100% sure about it - what would be enabled/disabled by default?
I think that this package handles sensitive data and cause of this the user should be 100% aware of what this package does on his machine.
So yes: it will help the lazy dev to use it - but it has also the risk that this package does things that the dev doesn't want it to do.

So just want to open a critical discussion, about pro-con, before doing this PR.