jrquick17/ng-speed-test

File size unit is wrong

Closed this issue · 1 comments

mwmw7 commented 
// https://raw.githubusercontent.com/jrquick17/ng-speed-test/02c59e4afde67c35a5ba74014b91d44b33c0b3fe/demo/src/assets/500kb.jpg
// 500kb      // 408949 kb

I think 408949 bytes is right

README and comments have wrong unit

image

jrquick17 commented

This is a known discrepancy which we do call out in the README.
dgns

The code does use the exact byte size so the speed checks out of the box should be accurate. Ideally the image would be exactly 500kb but not a priority at the moment. If you have images that match then feel free to submit a pull request.