jrxFive/python-nomad

No documentation on `.address` in class Nomad

wimax-grapl opened this issue · 2 comments

wimax-grapl commented

https://github.com/jrxFive/python-nomad/blob/master/nomad/__init__.py

One has to drill down to the Requester object to learn that address takes precedence over host/port.

python-nomad/nomad/api/base.py

Line 53 in f6dcba8

def _url_builder(self, endpoint):

if anything, this should be some sort of xor (throw an exception if address and [host/port] are specified)

jonathanrcross commented

Hey @wimax-grapl, sorry for getting burned by that... We'll certainly add to the docstring and possible add a warning about have both parameters set, don't want to introduce a break change.

wimax-grapl commented