js-dxtools/webpack-validator

`cheap-module-inline-source-map` is incorrectly marked as invalid

0xR opened this issue · 7 comments

0xR commented

It should be valid since its in the documentation:
https://webpack.github.io/docs/configuration.html

Running latest validator, this is my output:

[1] "devtool" with value "cheap-module-inline-source-map" fails to match the required pattern: /^(#@|@|#)?(eval$|cheap-eval-source-map$|cheap-source-map$|cheap-module-eval-source-map$|cheap-module-source-map$|eval-source-map$|source-map$|hidden-source-map$|inline-source-map)/

You probably mean cheap-module-eval-source-map.

cheap-module-inline-source-map is not in the documentation.
http://webpack.github.io/docs/configuration.html#devtool

Pretty sure it's valid, isn't it? The doc says:

'Combinations are possible. hidden, inline, eval and pragma style are exclusive.
i. e. cheap-module-inline-source-map, cheap-eval-source-map, #@source-map'

+1

This should be valid as well.

devtool: "#cheap-module-eval-inline-source-map"

Here's the relevant code and tests. Pull requests are welcome! makeapullrequest.com 👍

@kentcdodds I think I caught all the combos.

Thanks @dkh215! This will be autoreleased in a few minutes. #118

Awesome, sure thing!